Template talk:Achievementbox

From Warcraft Wiki
Jump to navigation Jump to search

Notes

This only supports one achievement currently, I'm not really sure if it needs to support more. User:CoobraSssssssssssssssssssssssss User:CoobraFor Pony! {TDon't hiss at me.CIf you do things right, people won't be sure you've done anything at all.) 07:08, 21 September 2008 (UTC)

Added {{Neutral Icon Small}} and {{{faction}}} parameter to specify alliance/horde. CogHammer.gif Ose talk/3721 20:49, 23 October 2008 (UTC)

Styling

It would be nice if someone made it a little prettier, although this does generally fit into the wowwiki theme. I could see the table header being dark brown, yellow letters, and the achievement row being a golden color, or even an image, to match the game images. [Note 1] Howbizr (talk) 13:56, 21 September 2008 (UTC)

Have to think how it will look with all the skins. Yellow tends to not do well. It would just be best to use standard colors. User:CoobraSssssssssssssssssssssssss User:CoobraFor Pony! {TDon't hiss at me.CIf you do things right, people won't be sure you've done anything at all.) 22:03, 21 September 2008 (UTC)
References

Bullets break Points

For example:

Fixed -- foxlit (talk) 14:55, 19 October 2008 (UTC)
On second thought, since it only presents one achievement at a time, I've changed how it looks to take advantage of that. I also added {{{link}}} which can be passed a page name to link the achievement title to (if they end up having individual pages, it may be easier to simply use {{{name}}}, but that's another discussion). -- foxlit (talk) 15:15, 19 October 2008 (UTC)
Can you adjust the styling? This really breaks large tables. I have a feeling it's 30em width, but I'm not sure what else you changed. Figure it's faster if you just take a look. This table looked fine a minute ago.
I tried auto width. Seems better. -Howbizr (talk) 15:29, 19 October 2008 (UTC)

Broken icon

I don't know if it's the template or the icon. -Howbizr (talk) 18:55, 19 October 2008 (UTC)

Icon bug, not a template error. -- foxlit (talk) 20:43, 22 October 2008 (UTC) thumbnailing

Alternate look

{{Achievementbox/dev}} has the same functions as this template, but looks different. Thoughts? CogHammer.gif Ose talk/3721 19:59, 22 October 2008 (UTC)

The thing to consider is what the actual template is to be used for -- if this is the infobox/tooltip template, then yes, the /Dev style works (although it's going to be wider than any of our current infoboxes) and looks better at the same time. However, the "Part of the following achievement:" header suggests it's a navigational aid of some sort, probably at the end of some other article, which makes the tooltip style and float somewhat unsuitable for the purpose.
Just have to figure out what we're actually going to use this template for; I'm not quite convinced the current level of detail is useful when using the template as a navbox-style thing. -- foxlit (talk) 20:42, 22 October 2008 (UTC)
Let me address the "Part of the following achievement". First there are very few articles using this template yet, and I may actually be the primary author of them all. With that in mind, I'm pretty sure Coobra added that header when he created the template for me because in the beginning, I was just enhancing the Brewfest article to add better information about the Brewmaster achievement. However, that Brewfest article is still seriously huge, so in the end I decided against having the achievement in the main article. Ever since then, I've liked that pattern of making achievements their own pages much better. Its very parrallel to the organization of quests. However, I really miss the nice inline icons and mouseovers you get with {{questlong}} since there isn't an equivalent for achievements yet.
So with that in mind, I have just have two objectives I'm trying to push. If someone has the energy and ability, make the achievementlong template, a sister template to questlong, and make some kind of mechanism so we can get mouseovers. If that means using {{achievement}} or {{toolbox}} or whatever, I don't care. I do not have a burning desire to have a float-right toolbox, but if you need one to make the mouseover happen, that's fine.
The big goal for me is to break up the existing achievements pages, because they are seriously monolithic and cumbersome. The secondary goals are to make it easy to reference achievements inline from other articles, as well as having a place to reference achievement details. Right now your only option is to reference the huge "World Events Achievements" page which sucks. Not to mention, if you wanted to talk strategy for one achievement or another, there's really no space for it, so I think this would help with that regard as well. Thanks for your help guys - can't wait to see this in action. Smiley.gif -Howbizr (talk) 20:18, 23 October 2008 (UTC)
Oh and Ose - how do you feel about the gold colors? -Howbizr (talk) 20:26, 23 October 2008 (UTC)
Collerz ar kewl. So you want to create pages for every single achievement? It will be a lot of work, but I guess it will be required if the tooltip thing is to work. That brings up the question: should we have pseudo-namespace (prefix) for the achievements like we have with quests? CogHammer.gif Ose talk/3721 20:36, 23 October 2008 (UTC)
It will take a while (especially if it's just me), but it looks like all of the content is already out there - it just needs broken up into pages. And ya... I think it's probably worth while to move the files I started on to some kind of space. Is "Achievement:" too long, or should we go for something shorter? I think colors would be awesome.. I think just a little bit of gold isn't too offensive, even though most of the site is blue. It helps them stick out as "not a quest" and "not an item" in my mind. -Howbizr (talk) 01:34, 24 October 2008 (UTC)
Update: Check out {{Achievementbox/achievementlong}}. I used it in the example. I also tried to add some different styles for {{Achievementbox/dev}}. -Howbizr (talk) 23:50, 24 October 2008 (UTC)

I'm gone a week and look how this template went from blah to BAM! User:CoobraSssssssssssssssssssssssss User:CoobraFor Pony! {TDon't hiss at me.CIf you do things right, people won't be sure you've done anything at all.) 17:58, 25 October 2008 (UTC)

I'm really excited about it. Smiley.gif I'm commenting out the example while I break/fix it. It was murdering this page! I'll bring it back when it's done. -Howbizr (talk) 22:39, 25 October 2008 (UTC)
Update New demo. This is using both of the dev templates. So remaining questions - does it look ready? And should I start switching achievements over to a namespace, or leave as is? -Howbizr (talk) 07:03, 26 October 2008 (UTC)

Longest word is split into two lines

Any idea how to stop the longest line being split into two lines? Sanderdolphin (talk) 17:30, 24 October 2008 (UTC)

There are ways to stop lines from wrapping, but I'm not seeing any splits. --Pcj (TDrop me a line!C207,729 contributions and counting) 17:36, 24 October 2008 (UTC)
Oh, I see it. --Pcj (TDrop me a line!C207,729 contributions and counting) 17:37, 24 October 2008 (UTC)
Fixed. --Pcj (TDrop me a line!C207,729 contributions and counting) 17:39, 24 October 2008 (UTC)
This is still broken on pages such as  [Explore Elwynn Forest]. Can this be resolved? Alliance Crest GLACTURE  talk  contrib 19:27, 4 November 2008 (UTC)
I see what you mean now. I added {{achievement|<width>}} width=38em and it looks better now. I couldn't figure out an automatic way to do this, which is why there is the width option. -Howbizr (talk) 13:39, 5 November 2008 (UTC)

I promoted {{Achievementbox/dev}} - it seems pretty robust. I'm in the process of switching all the pages over. -Howbizr (talk) 03:51, 29 October 2008 (UTC)

Switch should be complete... -Howbizr (talk) 23:55, 29 October 2008 (UTC)

Cross Browser

I don't normally use IE 6, but I tried looking at  [Brewmaster] in IE6, and it was pretty good when you were logged in, but it was a disaster otherwise. If a cross-browser compliance guru could check it out the floats and such, that would be awesome. -Howbizr (talk) 01:37, 8 November 2008 (UTC)

Don't use IE6. --Pcj (TDrop me a line!C207,729 contributions and counting) 02:56, 8 November 2008 (UTC)
I don't (I was just looking out of curiosity), but I try to be realistic and assume that many people still do... I'd guess it still probably has 20% of the market share, whether I like that or not. Smiley.gif-Howbizr (talk) 03:53, 8 November 2008 (UTC)
There are worse problems with IE6 than that. --Pcj (TDrop me a line!C207,729 contributions and counting) 21:15, 11 November 2008 (UTC)

Rename achievement box/tooltip template

Should we rename this template to something like {{achievementbox}}, since usually the template for just a simple link would be called {{achievement}} to go with {{achievementlong}} similar to {{quest}} and {{questlong}} vs. {{questbox}}. I suggest this now, so the current usage (which is the exception) doesn't become entrenched.--Gengar orange 22x22.png Fandyllic (talk · contr) 6:11 PM PST 10 Nov 2008

I'd have to agree, Thats what I thought the original purpose of this template was supposed to be something placed into the article to let players know its part of a certain achievement, but with how it's become an infobox it should be moved to an appropriate template name, be it {{achievementbox}} or {{achievement infobox}}, either one is fine. User:CoobraSssssssssssssssssssssssss User:CoobraFor Pony! {TDon't hiss at me.CIf you do things right, people won't be sure you've done anything at all.) 01:47, 11 November 2008 (UTC)
Go for it Fandyllic. -Howbizr (talk) 01:47, 12 November 2008 (UTC)
Renamed to {{achievementbox}}. Gonna start renaming where {{achievement}} was used and then change it after all the boxes have been changed. --Gengar orange 22x22.png Fandyllic (talk · contr) 1:19 PM PST 12 Nov 2008
The {{achievement}} template now just creates a simple link like:  Out With It (or for a bad link:  Imaginary Achievement. If you try to use the template with a name= parameter like you would {{achievementbox}}, you will get something like:  [[{{{1}}}|{{{1}}}]]. --Gengar orange 22x22.png Fandyllic (talk · contr) 3:11 PM PST 12 Nov 2008

type={{{doc|<type>}}}

I notice that some of our existing achievement articles use type=<type> and others have type={{{doc|<type>}}}, as specified in the documentation. I assume that this is an old vs. new thing. Should we be looking at updating those using the old syntax to use {{{doc|<type>}}}? I can do this quite easily with pywikipediabot, and I think it's better to do it sooner rather than later, as the number of articles to edit is relatively small right now. If we correct the existing articles, it will remove instances of someone copying the old syntax from an existing article when creating new ones. --Murph (talk · contr) 04:49, 21 December 2008 (UTC)

I can't remember exactly who, and I'm too lazy to look at the history (which is rather annoying with templates), but I think an admin added it in. I really have no idea what that even does, other than I assumed there was a good reason, but ya, the older articles (probably mostly world events) are not all updated. I'd go ahead and bot it, if you don't mind! -Howbizr (talk) 07:11, 21 December 2008 (UTC)
It's a method of preventing auto-categorisation from a template falling through to another page which transcludes the page using the template. See the recent change to this talk page where I modified {{:For The Children}} to {{:For The Children|doc=}} to prevent this talk page being included in Category:World Events achievements. It's not yet a standard, but it might be sometime - see WoWWiki:Template Engineers/Guidelines project. I'll stick it on my todo list, it's not a particularly difficult job if you know your regexps. --Murph (talk · contr) 07:47, 21 December 2008 (UTC)
Ok, MurphBot has completed its first run on this, 100 articles updated. I'll run it periodically to catch any bad usage in new achievements articles, until we've got most of them in place. --Murph (talk · contr) 19:02, 22 December 2008 (UTC)
Looking around, I noticed there are some examples where the Help:Achievement articles/Preload boilerplate has not quite been used properly - mode and arg have been left as mode=<!--{{{mode|}}}--> and arg=<!--{{{arg|}}}-->, instead of having the comments removed as intended. I'm not sure if it's possible to fix the preload to prevent this, but it's easy for the bot to correct. Pre-change analysis with the bot suggests there's only a small number of pages where this is present, so I'm going ahead with it immediately. Looking further forward, I'll look at detecting examples where those parameters are absent and inserting them, but that's a little more complex. --Murph (talk · contr) 20:54, 22 December 2008 (UTC)
And that's the mode and arg parameters added to articles where they were missing. The pattern matching for it is moderately complex, so it's possible that I've missed some examples where the template was being used in an unusual manner, but I think I've probably got most of them. The next thing I've spotted is some usage which isn't wrapped by an wrapper - again that is a relatively complex one to fix. --Murph (talk · contr) 08:34, 23 December 2008 (UTC)
Not as bad as I first thought to fix the wrappers, although it's possible I may have missed unusual template usage. 4 examples found and fixed, and I'll also run that script periodically until the achievements are mostly done. --Murph (talk · contr) 09:45, 23 December 2008 (UTC)
I saw some of the changes that were on my watchlist, and they all looked good - some nice catches! Two more thoughts: As for the commented out modes in the preload, I couldn't figure out any other way to make them work correctly. If anyone can fix that, it would be awesome. Also, if you need help with regex, send it my way. I'm not an expert, but I did a lot of it when I was removing social security & credit cards numbers at a client. -Howbizr (talk) 10:48, 23 December 2008 (UTC)
I think I've fixed the Help:Achievement articles/Preload boilerplate. It took a good bit of fiddling around and reading the MediaWiki docs to figure it out, but the secret seems to be judicious use of <includeonly /> to stop the parser interpreting particular things. I'm going to mention it on the pump, and if there are no objections, I'll be fixing the other boilerplates in a similar fashion. --Murph (talk · contr) 23:26, 23 December 2008 (UTC)
Thanks for doing the legwork to get that fixed. Smiley.gif -Howbizr (talk) 17:23, 24 December 2008 (UTC)

Indentation break. Just in case anyone is interested, I have published my script containing all the regexps for standardising the usage. See User:MurphBot/Achievementbox. --Murph (talk · contr) 00:52, 28 December 2008 (UTC)

Invalid page title specified in a DEFAULTLINK tag

The above error is showing up on all achievement pages. Anyone know how to fix the template to correct this? -- Dark T Zeratul (talk) 19:43, 9 January 2011 (UTC)

The end of mode/arg

I would like to, at some point in the future, remove the |mode= and |arg= parameters (and probably also |disambigpage=) from this template's boilerplate. As far as I can tell, the two are only used to allow {{achievement}} and {{achievementlong}} to pull data from achievement articles to generate links. There are two possible ways this could be done: we could use the #data: parser function (similar to {{itemtip}}), or we could drop the linking templates altogether, and instead rely on default links (e.g.  [Hero of Shattrath]), which probably suffice in most circumstances. Any thoughts on this? — foxlit (talk) 02:50, 2 December 2011 (UTC)

I'm late to discussion, but my opinion is at least that {{achievementlong}} should be replaced with default links. {{achievement}} would be kept in its current state, just like {{item}} and {{loot}} are still used. --g0urra[T҂C] 07:39, 20 January 2012 (UTC)

Account-wide achievements

So I was thinking the best way to display these would be to put in a simple binary field for whether it's an account-wide achievement or not, and if it is, then the name of the achievement is in blue instead of yellow. What does everyone else think? Also, who wants to code it if we can do this? I'm a bit iffy on properly constructing if statements in templates. -- Dark T Zeratul (talk) 04:48, 31 August 2012 (UTC)

That could probably be done, but I don't really see the usefulness about marking those as being account-wide or not... --g0urra[T҂C] 12:28, 31 August 2012 (UTC)
Just to let people know that multiple characters can contribute to its completion. -- Dark T Zeratul (talk) 20:43, 31 August 2012 (UTC)
Any other thoughts on this? -- Dark T Zeratul (talk) 23:08, 11 September 2012 (UTC)