Template talk:Sort

From Warcraft Wiki
Jump to navigation Jump to search

One problem I see in this template, is when it's used in headings, it clutters up the TOC with the numbers (see Dungeons & Raids achievements for an example). --Pcj (TDrop me a line!C207,729 contributions and counting) 03:32, 26 July 2009 (UTC)

Same thing happens in text mode (yay elinks). I'm trying to figure something out before I file a bug in mwbz. --k_d3 04:07, 26 July 2009 (UTC)
It's not really a MediaWiki bug if ELinks is showing display:none, is it? I would say working as intended on the MW part of that one. --Pcj (TDrop me a line!C207,729 contributions and counting) 19:19, 26 July 2009 (UTC)
'twas my point, that. If I can figure out how to get elinks to hide something and it still shows up in the toc I'll file a bug upstream... --k_d3 00:59, 27 July 2009 (UTC)
And I never really intended it to be used in headings, but maybe that's a fault of mine on the doc. Pretty much was designed for tables w/ sortable, although I can't see why you couldn't use it in other instances as well. /chomp‎ Howbizr(t·c) 9:48 PM, 26 Jul 2009 (EDT)
The problem is mainly it was incorporated in the WoW/BC/WotLK icons. --Pcj (TDrop me a line!C207,729 contributions and counting) 01:55, 27 July 2009 (UTC)
If that change is causing problems, we'll roll it back. There's no reason we couldn't make a separate "sorted" version of {{wow-inline}} et. all for the pages that need it, so as not to break everything else. I'll let you guys think on it, just make sure we keep Morph in the loop. /chomp‎ Howbizr(t·c) 10:02 PM, 26 Jul 2009 (EDT)
Yeah, either separate templates or just use {{sort}} separate from the icons in the tables. --Pcj (TDrop me a line!C207,729 contributions and counting) 02:06, 27 July 2009 (UTC)
Ewww - did not think about the headings, that had the icons -- w3Schools giveth and they taketh I see -- (M o r p hJames E. Rooks, Jr. aka: Morph
Morphgnome & Morphdraenei
| C | TLeave me a message on my Discussion/Talk Page) IconSmall Gnome Male.gifMorphgnomeIconSmall Draenei Male.gifMorphdraenei 02:29, 27 July 2009 (UTC)
Would it work if we modified the 3 inlines ( to include a |sort= paramater that would then and only then add the {{sort}} template) -- on {{wow-inline}} vs {{wow-inline}} would make WoW Icon update.png and WoW Icon update.png{{sort|1}} and {{bc-inline}} has 2 and Wrath-Logo-Small.png has 3-- that way would not have to make a whole new template -- just add to existing one ? -- (M o r p hJames E. Rooks, Jr. aka: Morph
Morphgnome & Morphdraenei
| C | TLeave me a message on my Discussion/Talk Page) IconSmall Gnome Male.gifMorphgnomeIconSmall Draenei Male.gifMorphdraenei 02:40, 27 July 2009 (UTC)
Ya if they determine that's the best course of action, I'm down. /chomp‎ Howbizr(t·c) 10:45 PM, 26 Jul 2009 (EDT)
That would work. --Pcj (TDrop me a line!C207,729 contributions and counting) 02:47, 27 July 2009 (UTC)

So to get sorting, you just do {{wow-inline|}} instead of just {{wow-inline}}. That worked for all the templates except {{FactionIcon}} which needs {{FactionIcon|sort=}} because it already has an unnamed first parameter. If this seems like a good solution, I'll go ahead and update their documentation. Also are there any other templates that might need this? /chomp‎ Howbizr(t·c) 11:17 PM, 26 Jul 2009 (EDT)

That looks great. --Pcj (TDrop me a line!C207,729 contributions and counting) 03:20, 27 July 2009 (UTC)
Docs should all be updated. {{wow-inline}}, {{bc-inline}}, {{wotlk-inline}}, {{Alliance Icon Small}}, {{Horde Icon Small}}, {{Neutral Icon Small}}, {{FactionIcon}}. /chomp‎ Howbizr(t·c) 12:52 AM, 27 Jul 2009 (EDT)

Only marginally relevant: Why do we have icons in headings? Can we not put those icons somewhere else? --Eirik Ratcatcher (talk) 19:28, 27 July 2009 (UTC)

I'm certain we do, although I couldn't name pages off the top of my head. And, probably. /chomp‎ Howbizr(t·c) 8:01 AM, 28 Jul 2009 (EDT)