Template talk:Book

From Warcraft Wiki
Jump to navigation Jump to search

Bad background

I'm using the WoWWiki skin and the book text is dark brown on dark gray and is basically unreadable. Was this tested with any of the other skins? --Gengar orange 22x22.png Fandyllic (talk · contr) 2:51 PM PST 27 Feb 2008

It reads just fine for me, and I'm guessing for Zeal too. No one said anything during the testing phase, but I'm sure things can be altered if need be. User:CoobraSssssssssssssssssssssssss User:CoobraFor Pony! {TDon't hiss at me.CIf you do things right, people won't be sure you've done anything at all.) 23:09, 27 February 2008 (UTC)

Errant [edit] link

Getting a random [edit] link in the title, as seen User:Kaydeethree/Sandbox#Opt 2. Any way we can fix that? --k_d3 23:06, 29 February 2008 (UTC)

Yea...don't know why, but when you click on the edit within the book template it wants to edit the next section header, and if most cases the next section header is going to be external links or nothing at all, thus making the error. User:CoobraSssssssssssssssssssssssss User:CoobraFor Pony! {TDon't hiss at me.CIf you do things right, people won't be sure you've done anything at all.) 23:08, 29 February 2008 (UTC)
Fixed. --Pcj (TDrop me a line!C207,729 contributions and counting) 23:11, 29 February 2008 (UTC)
Well, maybe not...--Pcj (TDrop me a line!C207,729 contributions and counting) 23:18, 29 February 2008 (UTC)
I think it happens because the template creates a section in it, and you're clicking the link on the rendered page. When you click the link, there is no section in the actual source, so it completely screws up. --Pcj (TDrop me a line!C207,729 contributions and counting) 23:20, 29 February 2008 (UTC)
Is there a way to just prevent the "edit" link from even appearing? User:CoobraSssssssssssssssssssssssss User:CoobraFor Pony! {TDon't hiss at me.CIf you do things right, people won't be sure you've done anything at all.) 23:22, 29 February 2008 (UTC)
The template uses an internal <h4> which the parser handles like a ====. I'm poking around on {{Book/Dev}}. The first character is in CSS... Dunno how to override that. --k_d3 23:23, 29 February 2008 (UTC)
We can always add __NOEDITSECTION__ to {{book}}, but that removes all section edit links from the entire page. The only alternative is to use a DIV, SPAN, or table. --Pcj (TDrop me a line!C207,729 contributions and counting) 23:26, 29 February 2008 (UTC)
See http://meta.wikimedia.org/wiki/Help:Section#Editing_sections_of_included_templates --Pcj (TDrop me a line!C207,729 contributions and counting) 23:41, 29 February 2008 (UTC)
*Big sigh* You could have removed the edit link for books via common.css, partly the reason why i left a rule in for targetting it that does nothing but colours it to match the title. More importantly now though, the common.css and wowwiki.css need to be udpated, as they're targeting a h4 which no longer exists. It's probably also what is causing the error you were seeing with the first letter, as that's targetting the first div, which used to be the body, now it's the header. The header div needs a class now as well, as does the body (can't recall if nth-child work outside ff atm) and the selectors updated to match them. If that's lost on people and you don't know how to do any of that, let me know... --   09:16, 1 March 2008 (UTC)

CSS

Gotta love how the above got ignored. There's lots of CSS, and worst of all, colour realted styles in the template itself. Now adding sizing.. and in points of all things. It's all well and good having a dev version, but the resulting CSS should not be going into this template or any other for that matter. Seriosuly, can you move the new CSS back into the CSS files and take heed of what i said before this template starts accumulating cross-skin issues and layout problems. Taking a step back in the development of WoWWiki here... -- Zeal (T/C)  08:23, 30 May 2008 (UTC)