Forum:Achievementbox updates

Forums: Village pump → Achievementbox updates
(This topic is archived. Please do not edit this page!)

So, if anyone was paying attention a month ago, I've been working on updating {{achievementbox}} for 2013. {{achievementbox/dev}} is more-or-less ready to go, but there are some stylistic differences from achievementbox and I'd like buy-in/edits from other editors before pushing it live. I've got a few test cases implemented on the bottom of the page. You will need to import my css to see the tooltips properly.

This is part of a longer-term desire to move achievementbox to the UsingData paradigm (as {{achievementtip}}) and retire some of the wrapper templates that wind up transcluding whole achievement articles.

Thoughts? Preferences? I'm not dead-set on the external icon, but I do think it looks better than having the icon on the left side inside the tooltip. --k_d³ 19:33, 16 March 2013 (UTC)

I added a slightly modified version of your CSS into MediaWiki:Common.css; it probably shouldn't conflict with anything else, and getting a widely-available preview of how things will look like is good. Unfortunately, it's going to be a while before the updated stylesheet reaches anyone.

Handling the two-column layout for criteria using lists is convenient, but results in a layout that's worse than the current table-based solution: compare Stormbreaker/dev to  [Stormbreaker]: if the column widths differ significantly, the forced 49% width on list items ends up making the tooltip needlessly wide.

The "10 points" text looks awkward when it's right-aligned in an empty line at the end of the tooltip. Moving it to either align with the Rewards line (which unfortunately doesn't always exist) or the achievement title would probably be better.

As far as pushing it live is concerned, I think it would make sense to deploy the new template as {{achievementtip}}, and bot the relevant article changes (such as removing |image= outright, and adding the {{#data:...}} boilerplate). I don't think there are any wrapper templates that actually transclude achievement articles, so the transition could probably be easily handled by bots. — foxlit (talk) 17:26, 18 March 2013 (UTC)

Re 2-column: I'm all ears for a better solution. The biggest thing I'm looking for is no display formatting in template calls (like we currently have to do with the col-begin/col-2/col-end thing). The template should handle the formatting for us... as that's the whole point of templates!

I'm not pleased with the points location (and the faction-tag, which is currently on the bottom left of the same line as points - see Kirin Tor Offensive (achievement)/dev). I can (and probably will) move points to top-right, but that plays badly with long achievement titles (such as When in Ihgaluk, Do as the Skumblade Do‎/dev). Looking for ideas there too.

Since {{achievementlong}} doesn't transclude the articles any more, I agree with the fork to achievementtip. I'm not aware of any other templates that interact with achievmentbox's |mode= and |arg= parameters. --k_d³ 17:50, 18 March 2013 (UTC)

The sitewide css has finally updated. I've moved points and faction to the top-right; points on the name line, faction on the description line. The long-name-and-points situation actually works fine now, despite my earlier testing, so no issues there. I'd prefer to not have any images inside the tooltip, but considering we have since 3.0, eh... I can live with it. If we do go that route I'd move the faction tag (as the alliance/horde icon) back to left of the name, then.

There is another option for 2-column than my ham-fisted 49%-width method, namely the CSS3 column-count property. The major caveat is that the property doesn't work in IE<10 and Opera<11.1. We already use it in {{reflist}}, so there is precedent.

At this point, I don't see anything substantive keeping achievementtip from going live. Does anyone have any thoughts? If there's no objection, we can move it live whenever. I'll probably do so in a day or two.

As an aside, now that the criteria parameter doesn't require any manual formatting to create a 2-column list, it should be pretty easy to hook up achievement-creation js the same way we do for items, which is a nice bonus. --k_d³ 06:06, 20 March 2013 (UTC)

Personally, I think the icons would look better -- the spelled-out "10 points" phrase looks a bit strange to me. Putting faction icons next to the titles of the achievements that are faction-specific (i.e. not using the neutral icon anywhere) would probably be okay, but I don't have a strong preference on that.

Aside: it's far easier to generate the {{col-2}} formatting in Javascript than it is to get it the columns to look right using CSS; the hard part of item/achievement creation is getting the data (and figuring out if any of it needs to link with other articles), not generating the wikitext. — foxlit (talk) 23:51, 20 March 2013 (UTC)

Additional comments on the appearance and wikitext markup on Stormbreaker/dev versus the current  [Stormbreaker] would be helpful. — foxlit (talk) 22:55, 29 August 2013 (UTC)

I'd have to say I like it when the Icon of the achievement is inside the tooltip but the issue is that some of the information, like the acheivement points and some criteria, are running right off the tooltip. — SurafbrovWarcraft Wiki administrator T / C 23:21, 29 August 2013 (UTC)

But the other one with the achievement Icon out of the tooltip is much easier to read. — SurafbrovWarcraft Wiki administrator T / C 23:23, 29 August 2013 (UTC)

It will definitely take some getting used to, as I liked the icon on the inside. On the acheivement pages it does look a bit off. Sdkphoenix (talk) 01:39, 1 September 2013 (UTC)

In terms of feedback regarding the new template, I have to repeat Zdroid's observation that some criteria text is currently running out of the tooltip, as well as the box itself on the article proper. I assume the intention is to have the box stretch to fit criteria? Also, yes, the icon did look better in the box, and also matched the in-game display more closely.  [Stormbreaker] (for example) certainly has room for the icon inside the box - is there a reason for placing it outside? It also takes up a little more space on article pages that way, and creates some additional empty space where the article text doesn't fill in. -- Taohinton (talk) 18:39, 10 September 2013 (UTC)

So, about the text overflow: {{achievementtip}} uses a larger font size, and imposes a tighter limit on maximum box width by default. Unless your browser supports css intrinsic & extrinsic sizing (like recent versions of Chrome, Firefox, and Safari), the criteria list may overflow the width allowed for the tooltip. Pages on which this is a problem can be fixed by adding a |max-width=40em (adjust the value accordingly) parameter to the template. There's a possibility that I might be thinking of the wrong issue; in any case, it'd be helpful to know which browser (and what version) you're using, and which articles are affected by the problem you're observing.

The {{achievementbox}} way of handling achievement icons looks awkward to me -- the vertical spacing around the achievement description seems very inconsistent. You could grab a sandbox or a /dev fork and sketch out how {{achievementtip}} would look like with an icon inside the tooltip; it might be workable. In general, I don't think that striving to replicate the in-game UI is a good idea: the in-game achievement list is much wider than we can reasonably make the tooltip. On the other hand, the current behavior of reserving a 50px gutter around the whole tooltip isn't great either. — foxlit (talk) 01:51, 21 September 2013 (UTC)